[Doc] css modules tutorial #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalcaben
added
pkg:pwa-devdocs
documentation
|
tjwiebell
suggested changes
Apr 17, 2020
Comment on lines
87
to
93
| const { | ||
| content, | ||
| root, | ||
| root_highPriority, | ||
| root_lowPriority, | ||
| root_normalPriority | ||
| } = buttonOverrides; |
There was a problem hiding this comment.
Seems odd to destructure here only to create the exact same object shape below, and with long hand. A better example might be to show the contents of myButtonWrapper.css, and pass it directly without destructuring, which might be more effort than it's worth (maybe don't mock up fake properties, just show those class names exist in that file).
Another reason to destructure would be when names are not exactly the same, but that's not the case here.
m2-community-project
bot
moved this from Ready for Review
to Changes Requested
in Pull Request Progress
tjwiebell
suggested changes
Apr 20, 2020
pwa-devdocs/src/tutorials/pwa-studio-fundamentals/css-modules/index.md
Outdated
Show resolved
Hide resolved
…index.md Co-Authored-By: Tommy Wiebell <twiebell@adobe.com>
tjwiebell
approved these changes
Apr 22, 2020
m2-community-project
bot
moved this from Changes Requested
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR revises and publishes the css modules tutorial contributed by @rossmc
Related Issue
Closes PWA-304
Acceptance
any developer
Verification Stakeholders
any developer
Specification
Verification Steps
cd pwa-devdocsyarn lint src/tutorials/pwa-studio-fundamentals/css-modules/index.mdyarn developScreenshots / Screen Captures (if appropriate)
Checklist