Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fixes incorrect propType in order confirmation page. #2375

Merged
merged 2 commits into from
May 1, 2020
Merged

[chore] Fixes incorrect propType in order confirmation page. #2375

merged 2 commits into from
May 1, 2020

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented May 1, 2020

Description

Fixes prop type error.

Related Issue

Closes PWA-549.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Place an order with your console open in local development (CI deployment disables prop types warnings).
  2. Verify no prop type error is shown.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@sirugh
Fixes incorrect propType in order confirmation page.
6c1d5c7 
Signed-off-by: sirugh <rugh@adobe.com>
@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label May 1, 2020
@sirugh sirugh changed the title Fixes incorrect propType in order confirmation page. [chore] Fixes incorrect propType in order confirmation page. May 1, 2020
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress May 1, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented May 1, 2020 •
edited

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-549.

Generated by 🚫 dangerJS against d2d554c

revanth0212
revanth0212 approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@revanth0212 revanth0212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress May 1, 2020
@dpatil-magento dpatil-magento merged commit db0d0d6 into develop May 1, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress May 1, 2020
@dpatil-magento dpatil-magento deleted the rugh/pwa-549-order-conf-proptype branch May 1, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revanth0212 revanth0212 revanth0212 approved these changes

Assignees

@revanth0212 revanth0212

Labels
pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sirugh @PWAStudioBot @revanth0212 @dpatil-magento