Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONT MERGE - test docker fix #2408

Closed
wants to merge 31 commits into from
Closed

Conversation

dpatil-magento
Copy link
Contributor

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to the FOO page.
  2. Verify the BAR shows up.
  3. Make sure BAZ does a thing.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
    [ ] I have added tests to cover my changes, if necessary.

James Zetlen and others added 30 commits April 29, 2020 17:18
Co-authored-by: Stephen <sirugh@users.noreply.github.com>
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress May 19, 2020
@dpatil-magento dpatil-magento changed the title Dpatil/test docker fix DONT MERGE - test docker fix May 19, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented May 19, 2020

Fails
🚫 Missing information in PR. Please fill out the "Description" section.
🚫 Missing information in PR. Please fill out the "Verification Steps" section.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 A version label is required. A maintainer must add one.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 6bb1047

@devops-pwa-codebuild
Copy link
Collaborator

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2408.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.65

@m2-community-project m2-community-project bot removed this from Ready for Review in Pull Request Progress May 21, 2020
@dpatil-magento dpatil-magento deleted the dpatil/test-docker-fix branch May 21, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants