Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New userguide index and link #2418

Merged
merged 6 commits into from
Jun 3, 2020
Merged

Conversation

belbiy
Copy link
Contributor

@belbiy belbiy commented May 22, 2020

Description

This pull request updates the documentation search index and site switcher link for user guide.

Related Issue

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to docs page
  2. Click on the waffle menu to reveal the site switcher.
  3. See that Commerce User Guide now points to http://docs.magento.com/user-guide/

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
    [ ] I have added tests to cover my changes, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress May 22, 2020
@dshevtsov
Copy link

Relates to commerce-docs/devdocs-theme#57

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 3, 2020

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 0178b30

Copy link
Contributor

@jcalcaben jcalcaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the navigation in the FAQ page does not appear: /frequently-asked-questions/

@m2-community-project m2-community-project bot moved this from Ready for Review to Changes Requested in Pull Request Progress Jun 3, 2020
@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jun 3, 2020

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2418.pwa-venia.com : LH Performance Expected 0.85 Actual 0.57, LH Best Practices Expected 1 Actual 0.92
https://pr-2418.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.36, LH Best Practices Expected 1 Actual 0.92
https://pr-2418.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.5, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@dpatil-magento dpatil-magento self-requested a review June 3, 2020 22:31
@m2-community-project m2-community-project bot moved this from Changes Requested to Reviewer Approved in Pull Request Progress Jun 3, 2020
@dpatil-magento dpatil-magento merged commit 0b58787 into magento:develop Jun 3, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants