-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] graphql tutorial #2432
[Doc] graphql tutorial #2432
Conversation
|
Performance Test Results The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate. https://pr-2432.pwa-venia.com : LH Performance Expected 0.85 Actual 0.52, LH Best Practices Expected 1 Actual 0.92, WPT Cache Expected 90 Actual 88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We have started to export objects from our .gql.js
files in the shape of
{
queries: {}
mutations: {}
}
but I don't think that's too important to capture here.
Likewise, there's some stylistic differences around checking for and displaying Loading
. Instead of doing Loading
at the end, we usually explicitly check for loading
and "early out" render a Loading
state.
Again, I'm not sure that makes much difference here.
pwa-devdocs/src/tutorials/pwa-studio-fundamentals/work-with-graphql/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick typo fix then 👍
…aphql/index.md Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com>
Description
This topic creates a tutorial about using GraphQL in PWA Studio.
Related Issue
Closes PWA-307
Acceptance
Any developer
Verification Stakeholders
Any developer
Specification
Verification Steps
pwa-devdocs
directory:cd pwa-devdocs
yarn lint src/tutorials/pwa-studio-fundamentals/work-with-graphql
yarn develop
Screenshots / Screen Captures (if appropriate)
Checklist
[ ] I have added tests to cover my changes, if necessary.