-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Fix Modal/Portal reference docs #2450
[Doc] Fix Modal/Portal reference docs #2450
Conversation
|
Performance Test Results The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate. https://pr-2450.pwa-venia.com : LH Performance Expected 0.85 Actual 0.55, LH Best Practices Expected 1 Actual 0.92 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcalcaben Thanks for catching this. 👍
91a7714
to
48f04a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approve after force push fun time 🎉
Verification steps look good. |
Description
This PR fixes the reference doc generation for the Modal component, which has been renamed to Portal.
Related Issue
Closes PWA-641
Acceptance
any developer
Verification Stakeholders
any developer
Specification
Verification Steps
pwa-devdocs
directory:cd pwa-devdocs
yarn develop
Screenshots / Screen Captures (if appropriate)
Checklist