Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses abbreviation for label if english text is not available #2476

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Jun 9, 2020

Description

AN (Netherlands Antilles) is not returning full_name_english for some reason. I have opened a bug with core but we can at least get ahead of it by falling back to the abbreviation for sort order.

Related Issue

Closes PWA-673.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to cart page or checkout page.
  2. In any countries dropdown, verify that the order is correct. Abbreviations will appear at the top, as capital letters are "bigger" than lowercase letters.

Screenshots / Screen Captures (if appropriate)

Image from Gyazo

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have updated the documentation accordingly, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jun 9, 2020
@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 9, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 9, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: MC-35052.

Generated by 🚫 dangerJS against b499096

@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jun 9, 2020

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2476.pwa-venia.com : LH Performance Expected 0.85 Actual 0.57, LH Best Practices Expected 1 Actual 0.92
https://pr-2476.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.36, LH Best Practices Expected 1 Actual 0.92
https://pr-2476.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.49, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Jun 10, 2020
@dpatil-magento dpatil-magento merged commit 72d2705 into develop Jun 11, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jun 11, 2020
@dpatil-magento dpatil-magento deleted the rugh/pwa-673-countries-order branch June 11, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

6 participants