-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Stable sort changes for v8 #2497
Conversation
Signed-off-by: sirugh <rugh@adobe.com>
147fe09
to
bd628ca
Compare
LogERROR ON TASK: unitTests
|
Performance Test Results The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate. https://pr-2497.pwa-venia.com : LH Performance Expected 0.85 Actual 0.57, LH Best Practices Expected 1 Actual 0.92 |
Updated CI test build node to 12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! I should have known better than to use that sort predicate before.
packages/peregrine/lib/talons/CheckoutPage/tests/useCheckoutPage.spec.js already exists on I have verified this pr on local and on CI with node 10 and 12, looks good. |
Description
Array.sort changed from node 10 to node 12. The sort function used here was not resilient to this, so it broke.
https://v8.dev/features/stable-sort
nodejs/node#27871
Related Issue
Closes PWA-690.
Acceptance
Verification Stakeholders
@zetlen
Specification
Verification Steps
nvm install 12
nvm use 12
yarn clean:all
yarn install
yarn test --coverage=0 packages/pwa-buildpack/lib/Utilities/__tests__/loadEnvironment.spec.js
Screenshots / Screen Captures (if appropriate)
Checklist