[PWA-623]: Update Venia's inputs #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- copy tokens to `venia-ui` - move index.css to `venia-ui` - update global vars and move to tokens - update custom property name references
- update serif font fallback value - update @font-face weights in templates - add serif @font-face in templates
# Conflicts: # packages/venia-concept/template.html # packages/venia-ui/lib/components/Footer/footer.css # packages/venia-ui/templates/default-font-include.mst
- use absolute paths to import `venia-ui` in `venia-concept`
- update existing CSS custom properties to use the new values
- Initial styling for new button styles
- use functional color notation
- Fix various buttons throughout the app
- Fix various buttons throughout the app
- Create <LinkButton /> component
- Update hover state to new colors - Fix various buttons throughout site - Fix estimate shipping info inconsistencies
# Conflicts: # packages/venia-ui/lib/tokens.css
- Update unit test snapshots
- Update filter and sort buttons - Make icons the same color in account area - Fix shipping estimate button
- Prettier & update snapshots
- Update all colors to match new designs
- Fix color commas
- Revert style guide changes
- Update teal colour to use blue
- update style for text inputs - update icon size within text inputs
# Conflicts: # packages/venia-ui/lib/components/Button/button.css # packages/venia-ui/lib/components/Checkout/flow.css # packages/venia-ui/lib/components/MiniCart/emptyMiniCartBody.css # packages/venia-ui/lib/components/ProductSort/productSort.css # packages/venia-ui/lib/components/SignIn/signIn.css # packages/venia-ui/lib/tokens.css
- Update search page filter button
- update style for search input with autocomplete dropdown
- Update usage of rgba with var usage - Fix flex- usage
m2-community-project
bot
moved this from Changes Requested
to Review in Progress
in Pull Request Progress
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
- use class modifiers
- fix stepper style cascading - update error message style
- remove redundant properties
- remove unused props
- remove unused class
jimbo
previously approved these changes
Jul 13, 2020
tjwiebell
previously approved these changes
Jul 13, 2020
Co-authored-by: Tommy Wiebell <twiebell@adobe.com>
tjwiebell
approved these changes
Jul 14, 2020
jimbo
approved these changes
Jul 14, 2020
|
@jimbo we see minor issue in Android device where Radios in Qty drop down, County/State in shipping form dropdown does not look same as rest of site. But its very specific to how android handles it, iOS don't have issue as there is no Radios on these fields. Does this needs to be handled? cc @anthoula
|
That's working as intended. No fix necessary. 👍 |
|
QA Approved. |
m2-community-project
bot
moved this from Review in Progress
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust input styles to match the new design
Related Issue
https://jira.corp.magento.com/browse/PWA-623
Acceptance
Verification Stakeholders
@soumya-ashok
@jimbo
@dpatil-magento
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist