Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-712: Fix Chrome prev / next carousel button placement #2512

Merged
merged 4 commits into from
Jun 25, 2020
Merged

PWA-712: Fix Chrome prev / next carousel button placement #2512

merged 4 commits into from
Jun 25, 2020

Conversation

davemacaulay
Copy link
Contributor

Description

They should be in the center of the image but they are instead at the top of the image:
https://i.gyazo.com/98b75a0fb607669e627f2d1a3091b415.gif

Related Issue

https://jira.corp.magento.com/browse/PWA-712

Acceptance

Verification Stakeholders

@jimbo
@sirugh

Specification

Verification Steps

  1. Check previous / next in Chrome mobile

Screenshots / Screen Captures (if appropriate)

https://i.gyazo.com/98b75a0fb607669e627f2d1a3091b415.gif

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have updated the documentation accordingly, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jun 25, 2020
@davemacaulay davemacaulay added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 25, 2020
@davemacaulay davemacaulay mentioned this pull request Jun 25, 2020
Closed
2 tasks
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 25, 2020 •
edited

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-712.

Generated by 🚫 dangerJS against b1c64b1

@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jun 25, 2020 •
edited

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2512.pwa-venia.com : LH Performance Expected 0.85 Actual 0.57, LH Best Practices Expected 1 Actual 0.92
https://pr-2512.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.33, LH Best Practices Expected 1 Actual 0.92
https://pr-2512.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.5, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

sirugh
sirugh previously approved these changes Jun 25, 2020
View reviewed changes
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Jun 25, 2020
jimbo
jimbo previously approved these changes Jun 25, 2020
View reviewed changes
@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Jun 25, 2020
@davemacaulay davemacaulay dismissed stale reviews from jimbo and sirugh via b00c2e7 June 25, 2020 16:34
@dpatil-magento
Copy link
Contributor

QA Approved.

@dpatil-magento dpatil-magento merged commit c036513 into magento:release/7.0 Jun 25, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jun 25, 2020
@dpatil-magento dpatil-magento mentioned this pull request Jul 14, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirugh sirugh sirugh approved these changes

@jimbo jimbo jimbo approved these changes

Assignees

@sirugh sirugh

@jimbo jimbo

Labels
pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@davemacaulay @PWAStudioBot @devops-pwa-codebuild @dpatil-magento @sirugh @jimbo