[PWA-281] My Account: Wishlist (Skeleton)

[tjwiebell]

Should be merged after #2611, which includes left navigation auto close logic.

Description

As a shopper (authenticated), I want to view/modify/delete wishlists under my account.

In-scope:

Create Skeleton for

Favorites View
Single
Multiple
Saved Item View
Requirements:

CE: only support for 1 List per shopper/account
EE: allows for Multiple List per shopper/account
Ensure additional stories are created to link new favorites/wishlist feature to cart and PDP workflows

Endstate:
When the shopper is authenticated and selects the "favorites list" menu item they are directed to the favorites view/page.

Related Issue

• [PWA-281] My Account: Wishlist (Skeleton)

Acceptance

Verification Stakeholders

Specification

Verification Steps

In the scope of this PR, wishlist data is currently mocked and will always return a single list with no items in it

1. Login as a Customer
2. Using either of the menus, select Favorites Lists
3. Verify that skeleton is rendered with mocked data
4. On CE, verify there is no Create a list button

Screenshots / Screen Captures (if appropriate)

Checklist

• I have added tests to cover my changes, if necessary.

• I have updated the documentation accordingly, if necessary.

[PWAStudioBot]

	Messages
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Associated JIRA tickets: PWA-281.

Generated by 🚫 dangerJS against 6429a65

[devops-pwa-codebuild]

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2620.pwa-venia.com : LH Performance Expected 0.85 Actual 0.34, LH Accessibility Expected 1 Actual 0.97, LH Best Practices Expected 1 Actual 0.93, WPT Cache Expected 90 Actual 38
https://pr-2620.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.35, LH Best Practices Expected 1 Actual 0.93
https://pr-2620.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.41, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.93, WPT Cache Expected 65 Actual 50

[schensley]

Thanks @tjwiebell things look really good. UX approved.

[sirugh]

Two minor requests, but otherwise great job!

[dpatil-magento]

@tjwiebell Other than Safari link wrapping issue rest all looks good.

[supernova-at]

QA

Verification Steps

✅ Verification Steps complete

Other

The horizontal kebab menu

When there are no items in the list, this button doesn't do anything. I realize its functionality is probably included in a subsequent ticket but if the functionality really is "do nothing" when there are no items in the list, can we remove or disable it in that case?

[tjwiebell]

Other

The horizontal kebab menu

When there are no items in the list, this button doesn't do anything. I realize its functionality is probably included in a subsequent ticket but if the functionality really is "do nothing" when there are no items in the list, can we remove or disable it in that case?

@supernova-at The upcoming mocks indicate this will have options for sharing, editing, and deleting a list; with the latter option being most relevant to an empty list. I think this is fine in scope of the skeleton, but a good observation that we should add to PWA-632. Open Source backends probably shouldn't have a delete or edit option, so up to UX if we want empty lists to be shareable.