Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GIF files in Webpack config #2714

Merged
merged 2 commits into from Oct 6, 2020
Merged

Support GIF files in Webpack config #2714

merged 2 commits into from Oct 6, 2020

Conversation

brendanfalkowski
Copy link
Contributor

Description

Adds support for .gif files in Webpack config.

We imported a module that contains some GIF files, and buildpack threw on error about this.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Add a GIF file to your project.
  2. Import it in any component.

Screenshots / Screen Captures (if appropriate)

Screen Shot 2020-09-17 at 5 25 39 PM

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Sep 18, 2020

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against c9af832

Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's odd that all of the other regular expressions include gif, but this one doesn't. Approved.

Also, I see you alphabetizing things.

alphabetize

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Sep 24, 2020
@brendanfalkowski
Copy link
Contributor Author

^^^ How I see myself alphabetizing things.

And how I actually look alphabetizing things:

giphy

@tjwiebell
Copy link
Contributor

Tracking internally with PWA-954.

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label Oct 6, 2020
@tjwiebell
Copy link
Contributor

Added a gif to local develop branch to confirm bug and got the dreaded white screen of death; checking out this branch the asset now display without error.

QA Pass ✅

@tjwiebell tjwiebell merged commit 15eb887 into magento:develop Oct 6, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants