Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add adobe logo #2812

Merged
merged 3 commits into from Oct 22, 2020
Merged

[Docs] Add adobe logo #2812

merged 3 commits into from Oct 22, 2020

Conversation

belbiy
Copy link
Contributor

@belbiy belbiy commented Oct 22, 2020

Description

This PR adds Adobe logo to the header.

It also fixes a bug with columns on the home page

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to docs home page
  2. See Adobe logo in top left
  3. See tiles in 3 columns and not 1.

Screenshots / Screen Captures (if appropriate)

Screen Shot 2020-10-22 at 3 18 28 PM

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Oct 22, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Oct 22, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 22, 2020

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 0a145e3

@dpatil-magento dpatil-magento merged commit a07f583 into magento:develop Oct 22, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Oct 22, 2020
@belbiy belbiy deleted the yb_adobe-logo branch October 28, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants