Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] #3102 Create a new Target for EditModal and Summary #3103

Merged
merged 28 commits into from Jun 11, 2021

Conversation

larsroettig
Copy link
Member

@larsroettig larsroettig commented Apr 6, 2021

Description

This Pull request allows used to move Braintree in a separated extension also allows third party developers
to create fully integrated payment methods

Breaking Changes in This PR

  • PaymentInformation/summary.js renders a "summary" view of a payment method, if configured via intercept, or just a title.
  • PaymentInformation/useSummary.js incoming props only expect classes and operations, return props now only isLoading and selectedPaymentMethod.
  • PaymentInformation/summary.gql.js export modified to single object instead of queries/mutations properties.
  • PaymentInformation/useEditModal.js handleDropinReady renamed to handlePaymentReady
  • PaymentInformation/editModal.js no longer uses classes, now renders an "editable" view of a payment method, if configured via intercept.

Related Issue

Closes #3102

Acceptance

Verification Stakeholders

@sirugh

Specification

Verification Steps

  1. Add Products to Cart
  2. Go to checkout
  3. Braintree behave live development branch on edit and summery page
  4. There two new extension points

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Apr 6, 2021
@larsroettig larsroettig changed the title #3102 Create a new Target for Edit Modal [FEATURE] #3102 Create a new Target for EditModal Apr 6, 2021
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Apr 6, 2021

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 0899e5e

@larsroettig larsroettig changed the title [FEATURE] #3102 Create a new Target for EditModal [FEATURE] #3102 Create a new Target for EditModal and Summery May 13, 2021
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress May 13, 2021
@sirugh sirugh marked this pull request as ready for review May 13, 2021 15:37
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback left! Please make sure the propTypes are all correct :)

@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Request Progress May 15, 2021
@larsroettig
Copy link
Member Author

@anthoula I did some tree analyses today, change some imports to lazy and try analyses if we have any rendering problem
but looks like there is not so much to optimize with much more afford

PR
Screenshot from 2021-06-09 15-48-43

@anthoula
Copy link
Contributor

anthoula commented Jun 9, 2021

@anthoula I did some tree analyses today, change some imports to lazy and try analyses if we have any rendering problem
but looks like there is not so much to optimize with much more afford

@larsroettig Thank you for looking into this. Your new changes improved the warning - went from 2.9s to 2.5s. We will open up a follow-up ticket to address the warning, and not hold up this PR.

@anthoula anthoula requested a review from sirugh June 9, 2021 16:26
sirugh
sirugh previously approved these changes Jun 9, 2021
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, lazy is so easy :)

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Jun 9, 2021
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Review in Progress in Pull Request Progress Jun 9, 2021
anthoula and others added 2 commits June 9, 2021 15:10
…on/__tests__/paymentInformation.spec.js

Co-authored-by: Stephen <sirugh@users.noreply.github.com>
@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Jun 9, 2021
@anthoula
Copy link
Contributor

✅ QA approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[feature]: EditModal should not depend on CreditCard
7 participants