Regression Fix - Content shifted under layered nav on PLP #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinconabree
changed the title
tjwiebell
added
the
version: Minor
tjwiebell
previously approved these changes
Jul 21, 2021
m2-community-project
bot
moved this from Ready for Review
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
tjwiebell
reviewed
Jul 21, 2021
| display: flex; | ||
| flex-wrap: wrap; | ||
| flex-wrap: nowrap; |
There was a problem hiding this comment.
Tiny nitpick, but this should be the default so this line is redundant; consider removing.
Suggested change
| flex-wrap: nowrap; |
There was a problem hiding this comment.
@tjwiebell Good find! I've removed the value and it's still working.
m2-community-project
bot
moved this from Reviewer Approved
to Review in Progress
in Pull Request Progress
eug123
approved these changes
Jul 22, 2021
m2-community-project
bot
moved this from Review in Progress
to Reviewer Approved
in Pull Request Progress
|
✅ QA Approved QA Verification Steps PWA-1897 |
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing regression introduced by Layered Navigation where content shifts below the layered nav if an item's title exceeds the space available.
Related Issue
Fixes issue https://jira.corp.magento.com/browse/PWA-1897
Acceptance
Verification Stakeholders
@revanth0212
Verification Steps
Test scenario(s) for direct fix/feature
Is Browser/Device testing needed?
Yes, device testing is needed as layered nav + gallery UI components may be impacted on mobile and desktop
Breaking Changes (if any)
Layout/targetable references of category content changed.
Checklist