Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression Fix - Account chip welcome message in non-default store view #3286

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Regression Fix - Account chip welcome message in non-default store view #3286

merged 2 commits into from
Jul 22, 2021

Conversation

justinconabree
Copy link
Contributor

Description

When in the french store view, without the french language pack, the account chip's welcome message when logged in was simply "Hi". This PR applies the proper message templating to the default message

Related Issue

https://jira.corp.magento.com/browse/PWA-1239

Acceptance

Verification Stakeholders

@revanth0212

Verification Steps

Test scenario(s) for direct fix/feature

  • Ensure language pack for French is not installed
  • Sign in to your customer account
  • Navigate to French store view
  • Validate that message contains customer's first name (ex "Hi, Justin")

Is Browser/Device testing needed?

No

Any ad-hoc/edge case scenarios that need to be considered?

No

Breaking Changes (if any)

None

Checklist

N/A

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jul 20, 2021
@justinconabree justinconabree changed the base branch from develop to release/11.0 July 20, 2021 18:53
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jul 20, 2021 •
edited
Loading

Messages
📖

Associated JIRA tickets: PWA-1239.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 057a4f0

@tjwiebell tjwiebell added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jul 21, 2021
@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Jul 21, 2021
@supernova-at supernova-at merged commit 57bc625 into release/11.0 Jul 22, 2021
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jul 22, 2021
@michaelyu0123 michaelyu0123 deleted the jconabree/PWA-1239-fix-account-chip-welcome-message branch February 1, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjwiebell tjwiebell tjwiebell approved these changes

Assignees

@tjwiebell tjwiebell

Labels
needs triage Partner: Absolunet Inc partners-contribution pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@justinconabree @PWAStudioBot @tjwiebell @supernova-at @magento-engcom-team @jcalcaben