-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cypress #3736
update cypress #3736
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run prettier, add a version label, and recommit, otherwise approved.
run cypress |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
Description
Improve cypress build time on CI and separate Functional and Snapshot tests for more control.
Related Issue
Closes https://jira.corp.magento.com/browse/PWA-2578.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
run cypress
should still work and overall build time to reduce from 20min to around 10mins.NOTE - In follow up ticket more changes to come where Functional and snapshot can be run together or separate.
Checklist