Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cypress #3736

Merged
merged 11 commits into from
Mar 22, 2022
Merged

update cypress #3736

merged 11 commits into from
Mar 22, 2022

Conversation

dpatil-magento
Copy link
Contributor

@dpatil-magento dpatil-magento commented Mar 14, 2022

Description

Improve cypress build time on CI and separate Functional and Snapshot tests for more control.

Related Issue

Closes https://jira.corp.magento.com/browse/PWA-2578.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

  1. run cypress should still work and overall build time to reduce from 20min to around 10mins.
    NOTE - In follow up ticket more changes to come where Functional and snapshot can be run together or separate.

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 14, 2022

Messages
📖

Associated JIRA tickets: PWA-2578.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 0e9d222

ericeoeur
ericeoeur previously approved these changes Mar 17, 2022
Copy link
Contributor

@ericeoeur ericeoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run prettier, add a version label, and recommit, otherwise approved.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Review in Progress in Pull Request Progress Mar 17, 2022
@dpatil-magento dpatil-magento added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 17, 2022
@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 21, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 21, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 21, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 21, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 21, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 21, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 21, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 22, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 22, 2022

Successfully started codebuild job for cypress

Copy link
Contributor

@ericeoeur ericeoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@dpatil-magento dpatil-magento merged commit f145f1d into develop Mar 22, 2022
@dpatil-magento dpatil-magento deleted the dev/cypressupdt branch March 22, 2022 16:44
@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Request Progress Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants