Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog update #3738

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Changelog update #3738

merged 5 commits into from
Mar 16, 2022

Conversation

bdenham
Copy link
Contributor

@bdenham bdenham commented Mar 14, 2022

Description

Updated CHANGELOG.md to consolidate lighthouse metrics into a single table. Also fixed a link.

Related Issue

Closes #PWA-2609.

Acceptance

Verification Stakeholders

@dpatil-magento

bdenham and others added 4 commits March 14, 2022 14:00
* Updated Changelog for 12.3

* Link fix

* Reworked the ordering

* Fixed link

* Fixed version numbers

* Added known issuee

* Added svg icons for lighthouse scores

* Updated lighthouse score svgs

* Updated lighthouse status for release notes

* Fixed link

Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Co-authored-by: Bruce Denham <bdenham@adobe.com>
# Conflicts:
#	CHANGELOG.md
# Conflicts:
#	CHANGELOG.md
@bdenham bdenham added pkg:pwa-devdocs version: Patch This changeset includes backwards compatible bug fixes. docs documentation labels Mar 14, 2022
@bdenham bdenham self-assigned this Mar 14, 2022
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Request Progress Mar 14, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 14, 2022

Fails
🚫 Missing "Verification Steps" section. Please add it back, with detail.
Messages
📖

Associated JIRA tickets: PWA-2609.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 17a70a4

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Mar 16, 2022
@dpatil-magento dpatil-magento merged commit 7840231 into develop Mar 16, 2022
@dpatil-magento dpatil-magento deleted the changelog_update branch March 16, 2022 20:04
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation needs triage pkg:pwa-devdocs Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants