Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Accessibility Enhancements - Group 1 #3857

Merged
merged 9 commits into from May 16, 2022
Merged

Conversation

tjwiebell
Copy link
Contributor

@tjwiebell tjwiebell commented May 13, 2022

Description

Group of PRs merged together for delivery

Related Issue

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label May 13, 2022
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress May 13, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented May 13, 2022

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 7ea2aab

@tjwiebell
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 13, 2022

Successfully started codebuild job for cypress

@tjwiebell
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 16, 2022

Successfully started codebuild job for cypress

@tjwiebell
Copy link
Contributor Author

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 16, 2022

Successfully started codebuild job for lighthouse-mobile

@tjwiebell
Copy link
Contributor Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 16, 2022

Successfully started codebuild job for lighthouse-desktop

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress May 16, 2022
@tjwiebell tjwiebell merged commit c897ff6 into develop May 16, 2022
@tjwiebell tjwiebell deleted the tommy/a11y-group-1 branch May 16, 2022 16:29
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress May 16, 2022
rwalter215 pushed a commit to rwalter215/pwa-studio that referenced this pull request May 25, 2022
* AC-2496::Contrast insufficient - light grey text (Checkout - Payment)
* AC-2490::Contrast insufficient - product image selected state indicator (Product Detail Page)
* AC-2496:index.module.css were not formatted
* AC-2785::Custom dropdown controls lack appropriate name and state information.
* AC-2785::modification in storeSwitcher.js and currencySwitcher.js as per yarn run lint
* AC-2785::added yarn prettier to the file Header/currencySwitcher.js

Co-authored-by: Rajesh Kumar <glo71317@adobe.com>
Co-authored-by: glo82145 <glo82145@adobe.com>
rwalter215 pushed a commit to rwalter215/pwa-studio that referenced this pull request May 26, 2022
* AC-2496::Contrast insufficient - light grey text (Checkout - Payment)
* AC-2490::Contrast insufficient - product image selected state indicator (Product Detail Page)
* AC-2496:index.module.css were not formatted
* AC-2785::Custom dropdown controls lack appropriate name and state information.
* AC-2785::modification in storeSwitcher.js and currencySwitcher.js as per yarn run lint
* AC-2785::added yarn prettier to the file Header/currencySwitcher.js

Co-authored-by: Rajesh Kumar <glo71317@adobe.com>
Co-authored-by: glo82145 <glo82145@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

5 participants