New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Accessibility Enhancements - Group 1 #3857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or (Product Detail Page)
…per yarn run lint
tjwiebell
added
the
version: Patch
This changeset includes backwards compatible bug fixes.
label
May 13, 2022
|
run cypress |
Successfully started codebuild job for |
tjwiebell
force-pushed
the
tommy/a11y-group-1
branch
from
May 13, 2022 22:56
4107c77
to
7ea2aab
Compare
run cypress |
Successfully started codebuild job for |
run lighthouse-mobile |
Successfully started codebuild job for |
run lighthouse-desktop |
Successfully started codebuild job for |
anthoula
approved these changes
May 16, 2022
m2-community-project
bot
moved this from Ready for Review
to Reviewer Approved
in Pull Request Progress
May 16, 2022
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
May 16, 2022
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
May 16, 2022
rwalter215
pushed a commit
to rwalter215/pwa-studio
that referenced
this pull request
May 25, 2022
* AC-2496::Contrast insufficient - light grey text (Checkout - Payment) * AC-2490::Contrast insufficient - product image selected state indicator (Product Detail Page) * AC-2496:index.module.css were not formatted * AC-2785::Custom dropdown controls lack appropriate name and state information. * AC-2785::modification in storeSwitcher.js and currencySwitcher.js as per yarn run lint * AC-2785::added yarn prettier to the file Header/currencySwitcher.js Co-authored-by: Rajesh Kumar <glo71317@adobe.com> Co-authored-by: glo82145 <glo82145@adobe.com>
rwalter215
pushed a commit
to rwalter215/pwa-studio
that referenced
this pull request
May 26, 2022
* AC-2496::Contrast insufficient - light grey text (Checkout - Payment) * AC-2490::Contrast insufficient - product image selected state indicator (Product Detail Page) * AC-2496:index.module.css were not formatted * AC-2785::Custom dropdown controls lack appropriate name and state information. * AC-2785::modification in storeSwitcher.js and currencySwitcher.js as per yarn run lint * AC-2785::added yarn prettier to the file Header/currencySwitcher.js Co-authored-by: Rajesh Kumar <glo71317@adobe.com> Co-authored-by: glo82145 <glo82145@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Group of PRs merged together for delivery
Related Issue
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist