Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent the body of the page from scrolling while the menu is open #3865

Merged
merged 12 commits into from
Nov 22, 2022

Conversation

huykon
Copy link
Contributor

@huykon huykon commented May 25, 2022

Description

When the menu is open, lock the page from scrolling, so that I can only scroll the inner content of the menu.
Prevent repaint by compensating for the loss of the vertical scrollbar when

Related Issue

Closes #3458.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented May 25, 2022

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 6bbdcd2

@huykon
Copy link
Contributor Author

huykon commented Sep 12, 2022

@magento/pwa-studio-maintainers anyone take a review?

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Nov 21, 2022
@jcalcaben jcalcaben added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Nov 21, 2022
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 22, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

dpatil-magento commented Nov 22, 2022

Verified Main menu, Filter Menu, User Account Edit modal overlay on chrome, FF, Safari, Android Chrome, iOS - Safari respectively, fix looks good. Failed Lighthouse and Cypress not related.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 6bbdcd2

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 22, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 22, 2022

Successfully started codebuild job for lighthouse-mobile

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 Lighthouse assertions failed 😔. All assertions must pass before this PR can be merged
https://pr-3865.pwa-venia.com/

categories.accessibility (minScore)

  • Expected: 1
  • Actual: 0.98
  • Result: Failed
🚫

node failed.

Log

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-6f10a8d6.json

Generated by 🚫 dangerJS against 6bbdcd2

@dpatil-magento dpatil-magento merged commit 5afac23 into magento:develop Nov 22, 2022
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Development

Successfully merging this pull request may close these issues.

[feature]: Prevent the body of the page from scrolling while the menu is open
4 participants