Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jconabree/issue 3873 talon exports #3874

Conversation

justinconabree
Copy link
Contributor

…rk correctly

Description

Certain hooks and talons were exporting default instead of a named export. Named exports are required for exposing talons and hooks for wrapping

Note: It would be nice to have a test that checks the export is available so this doesn't occur in the future. Or possibly leverage eslint-import-plugin's no-default-export rule

Related Issue

Closes #3873

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Is Browser/Device testing needed?

No

Breaking Changes (if any)

Export name changes for affected talons and hooks

Checklist

  • I have added tests to cover my changes, if necessary.
  • [ ] I have added translations for new strings, if necessary.
  • [ ] I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 1, 2022

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 4e7d9da

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jun 1, 2022
@jcalcaben jcalcaben added the version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. label Aug 22, 2022
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 23, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 24, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 24, 2022

Successfully started codebuild job for lighthouse-mobile

@dpatil-magento
Copy link
Contributor

QA Approved, would be merged in next major release.

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 2, 2022

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to use radio-boolean filter results in Category and Search pages:
    • AssertionError: Timed out retrying after 30000ms: Expected to find content: '0-100' within the element: [
    • , 4 more... ] and with the selector: '[data-cy="FilterList-item"]' but never did.
  • user should be able to add and remove products from wishlist:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

  • Validate validations:
    • AssertionError: Timed out retrying after 30000ms: expected '<div.newsletter-root-TID.col-span-6.gap-none.grid.items-start.max-w-[20rem].mx-auto.relative.sm_col-span-3>' to contain text 'Enter a valid email address.', but the text was 'Subscribe to VeniaRecieve the latest news, update and special offers right to your inbox.Unexpected token A in JSON at position 0EmailSubscribeSubscribe'

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 4e7d9da

@dpatil-magento
Copy link
Contributor

Cypress failures are not related.

@dpatil-magento dpatil-magento merged commit 3d4e958 into magento:develop Nov 2, 2022
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pagebuilder pkg:peregrine pkg:venia-ui Progress: done version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump.
Development

Successfully merging this pull request may close these issues.

[bug]: Certain talons and hooks cannot be wrapped
4 participants