Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch command failing during the compilation process initiated by docker #3955

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

medjabir
Copy link
Contributor

@medjabir medjabir commented Sep 5, 2022

Description

Fixing the permissions while copying source files from the build stage. Because yarn run watch throws an error Error: EACCES: permission denied, open 'template.generated.html' while trying to generate the template html file due to a permission error. See issue #3954 for more information.

Related Issue

Closes #3954.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

  • Verify if the bash script ./docker/run-docker runs and setup the containers successfully.

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@medjabir medjabir changed the title Update dev.dockerfile Watch command failing during the compilation process initiated by docker Sep 5, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 5, 2022

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against b136db1

@m2-community-project m2-community-project bot added this to Reviewer Approved in Pull Request Progress Sep 8, 2022
@m2-community-project m2-community-project bot moved this from Reviewer Approved to On Hold in Pull Request Progress Sep 8, 2022
@anthoula anthoula added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 8, 2022
@m2-community-project m2-community-project bot moved this from On Hold to Reviewer Approved in Pull Request Progress Sep 8, 2022
@anthoula
Copy link
Contributor

anthoula commented Sep 8, 2022

run all tests

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 8, 2022

Successfully started codebuild job for the following test suites:

cypress
lighthouse-desktop
lighthouse-mobile
pr-test
scaffold-pwa

@dpatil-magento dpatil-magento merged commit b9ba68a into magento:develop Sep 13, 2022
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

[bug]: Watch command failing during the compilation process initiated by docker
4 participants