BUG#AC-2485 No visual indication of focus on buttons. (pattern: Butto… #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns lack indication of focus)
|
…ns lack indication of focus)
…ns lack indication of focus)
…ns lack indication of focus)
…ns lack indication of focus)
…ns lack indication of focus)
…ns lack indication of focus)
|
@magento create issue from PR |
jcalcaben
requested changes
Nov 15, 2022
m2-community-project
bot
moved this from Ready for Review
to Changes Requested
in Pull Request Progress
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
…ns lack indication of focus)
jcalcaben
approved these changes
Nov 17, 2022
m2-community-project
bot
moved this from Changes Requested
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
dpatil-magento
added
the
version: Patch
|
run cypress |
|
Successfully started codebuild job for |
LogERROR ON TASK: cypressTests |
|
QA Approved. |
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ns lack indication of focus)
Description
Reproduction Steps
Locations (representative sample):
Landing Page
Search Results
Product Detail Page
Shopping Bag
Actual Behavior
There is no visual indication of keyboard focus of buttons when using TAB or SHIFT+TAB to navigate through controls of the page. For the following buttons:
Module 02 - Landing Page:
"Dot" icon buttons for homepage carousel
"Slider" buttons for "Top Sellers" carousel
Module 03 - Search Results Page:
Page selection buttons (which includes - First, Previous, Page #, Next, Last)
Module 04 - Product Detail Page:
QTY "-" and "+" buttons
Page controls on resize (200%) - "<", ">", and page dots
Module 05b - Shopping Bag:
QTY "-" and "+" buttons
Options "dots" button
Visual keyboard-only users can become disoriented when focus is not indicated.
Expected Behavior
Ensure that when actionable elements receive focus, that it appears on screen and that a visible focus indicator is present.
Related Issue
Closes https://jira.corp.adobe.com/browse/AC-2485
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
Resolved issues: