Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-2985: [bug]: Payment method always reverts to "Check / Money orde… #3969

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

anthoula
Copy link
Contributor

@anthoula anthoula commented Sep 30, 2022

…r" when there is an error with the transaction

Description

  • Set selected payment method mutation upon onChange event
  • Set initialSelectedMethod to selected_payment_method data
  • Update test coverage & snapshots

Related Issue

Closes #PWA-2985.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

…r” when there is an error with the transaction

- Set selected payment method mutation upon onChange event
- Set initialSelectedMethod to selected_payment_method data
- Update test coverage & snapshots
@anthoula anthoula added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Sep 30, 2022
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Sep 30, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 30, 2022

Messages
📖

Associated JIRA tickets: PWA-2985.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against a59b2f8

fnhipster
fnhipster previously approved these changes Sep 30, 2022
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 30, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

@anthoula Please check following observations -

  1. Cypress checkout tests failing because when there is only one payment method is available then it should be selected by default but currently even this case is waiting for user to select.

image

  1. Very minor, horizontal separation line before selecting payment method looks bit odd. Also if its ok to have it, the position needs bit adjusted. Currently its very close to second payment method.

image

…r” when there is an error with the transaction

- Set default/initial payment method
- Add tests
- Update padding
…r” when there is an error with the transaction

- Revert suggested snap update
@anthoula
Copy link
Contributor Author

anthoula commented Oct 3, 2022

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 3, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

QA Approved

@dpatil-magento dpatil-magento merged commit c78b9f9 into develop Oct 3, 2022
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Oct 3, 2022
@bdenham bdenham changed the title PWA-2985: [bug]: Payment method always reverts to “Check / Money orde… PWA-2985: [bug]: Payment method always reverts to "Check / Money orde… Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants