AC-6477-There's no message to inform the user the page refreshed its … #3971

glo82145 · 2022-10-03T09:49:43Z

…content by clicking/pressing one of the buttons.

Description

There's no message to inform the user the page refreshed its content by clicking/pressing one of the buttons.

Related Issue

Closes https://jira.corp.adobe.com/browse/AC-6477

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

I have added tests to cover my changes, if necessary.
I have added translations for new strings, if necessary.
I have updated the documentation accordingly, if necessary.

Resolved issues:

resolves [Issue] AC-6477-There's no message to inform the user the page refreshed its … #3992: AC-6477-There's no message to inform the user the page refreshed its …

…content by clicking/pressing one of the buttons.

pwa-studio-bot · 2022-10-03T09:58:31Z

	Messages
📖	Associated JIRA tickets: AC-6477.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 445d3cd

…content by clicking/pressing one of the buttons.

… content by clicking/pressing one of the buttons.

anthoula · 2022-10-28T15:28:47Z

@magento create issue from PR

anthoula

Hi @glo82145 - Thanks for looking at this. Would you run yarn prettier so that the linter check will pass for this PR? Thank you

…AccountChip/accountChip.js

glo82145 · 2022-11-07T12:04:57Z

Hi @glo82145 - Thanks for looking at this. Would you run yarn prettier so that the linter check will pass for this PR? Thank you

@anthoula Its done

anthoula · 2022-11-07T14:38:05Z

run cypress

pwa-test-bot · 2022-11-07T14:38:07Z

Successfully started codebuild job for cypress

anthoula · 2022-11-07T14:47:59Z

run lighthouse desktop

anthoula · 2022-11-07T14:48:10Z

run lighthouse mobile

pwa-studio-bot · 2022-11-07T14:48:50Z

	Fails
🚫	`node` failed.
🚫	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged user should be able to update their address book: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred. https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 445d3cd

dpatil-magento · 2022-11-09T05:52:57Z

run cypress

pwa-test-bot · 2022-11-09T05:53:00Z

Successfully started codebuild job for cypress

dpatil-magento · 2022-11-09T06:06:46Z

run lighthouse-desktop

pwa-test-bot · 2022-11-09T06:06:48Z

Successfully started codebuild job for lighthouse-desktop

dpatil-magento · 2022-11-09T06:06:51Z

run lighthouse-mobile

pwa-test-bot · 2022-11-09T06:06:52Z

Successfully started codebuild job for lighthouse-mobile

dpatil-magento · 2022-11-09T06:52:09Z

QA Approved, cypress failure unrelated.

AC-6477-There's no message to inform the user the page refreshed its …

a689c41

…content by clicking/pressing one of the buttons.

m2-community-project bot added this to Ready for Review in Pull Request Progress Oct 3, 2022

m2-community-project bot added the Progress: ready for review label Oct 3, 2022

Merge branch 'develop' into AC-6477

f39806c

pwa-studio-bot added the pkg:venia-ui label Oct 3, 2022

glo82145 and others added 8 commits October 3, 2022 15:31

AC-6477-There's no message to inform the user the page refreshed its …

6d29aeb

…content by clicking/pressing one of the buttons.

Merge branch 'AC-6477' of github.com:glo71317/pwa-studio into AC-6477

5f02696

AC-6477-There's no message to inform the user the page refreshed its …

ca79c41

…content by clicking/pressing one of the buttons.

AC-6477-There's no message to inform the user the page refreshed its …

226467a

…content by clicking/pressing one of the buttons.

AC-6477::There's no message to inform the user the page refreshed its…

f3bbb87

… content by clicking/pressing one of the buttons.

Merge branch 'develop' into AC-6477

c269483

AC-6477::Changed the logic as per QA suggestion

af17547

Merge branch 'AC-6477' of github.com:glo71317/pwa-studio into AC-6477

62b98d4

m2-assistant bot mentioned this pull request Oct 28, 2022

[Issue] AC-6477-There's no message to inform the user the page refreshed its … #3992

Closed

anthoula added the version: Patch This changeset includes backwards compatible bug fixes. label Nov 3, 2022

anthoula requested changes Nov 3, 2022

View reviewed changes

m2-community-project bot assigned anthoula Nov 3, 2022

m2-community-project bot moved this from Ready for Review to Changes Requested in Pull Request Progress Nov 3, 2022

m2-community-project bot added Progress: changes requested and removed Progress: ready for review labels Nov 3, 2022

glo82145 and others added 2 commits November 7, 2022 17:08

AC-6477::added yarn run prettier on packages/venia-ui/lib/components/…

9a3a58b

…AccountChip/accountChip.js

Merge branch 'develop' into AC-6477

1048d81

anthoula self-requested a review November 7, 2022 14:50

anthoula approved these changes Nov 7, 2022

View reviewed changes

m2-community-project bot moved this from Changes Requested to Reviewer Approved in Pull Request Progress Nov 7, 2022

m2-community-project bot added Progress: approved and removed Progress: changes requested labels Nov 7, 2022

Merge branch 'develop' into AC-6477

445d3cd

dpatil-magento merged commit b11b984 into magento:develop Nov 9, 2022

m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Nov 9, 2022

m2-community-project bot added Progress: done and removed Progress: approved labels Nov 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AC-6477-There's no message to inform the user the page refreshed its … #3971

AC-6477-There's no message to inform the user the page refreshed its … #3971

glo82145 commented Oct 3, 2022 •

edited by m2-assistant bot

pwa-studio-bot commented Oct 3, 2022 •

edited

anthoula commented Oct 28, 2022

anthoula left a comment

glo82145 commented Nov 7, 2022

anthoula commented Nov 7, 2022

pwa-test-bot bot commented Nov 7, 2022

anthoula commented Nov 7, 2022

anthoula commented Nov 7, 2022

pwa-studio-bot commented Nov 7, 2022 •

edited

dpatil-magento commented Nov 9, 2022

pwa-test-bot bot commented Nov 9, 2022

dpatil-magento commented Nov 9, 2022

pwa-test-bot bot commented Nov 9, 2022

dpatil-magento commented Nov 9, 2022

pwa-test-bot bot commented Nov 9, 2022

dpatil-magento commented Nov 9, 2022

AC-6477-There's no message to inform the user the page refreshed its … #3971

AC-6477-There's no message to inform the user the page refreshed its … #3971

Conversation

glo82145 commented Oct 3, 2022 • edited by m2-assistant bot

Description

Related Issue

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

Resolved issues:

pwa-studio-bot commented Oct 3, 2022 • edited

anthoula commented Oct 28, 2022

anthoula left a comment

Choose a reason for hiding this comment

glo82145 commented Nov 7, 2022

anthoula commented Nov 7, 2022

pwa-test-bot bot commented Nov 7, 2022

anthoula commented Nov 7, 2022

anthoula commented Nov 7, 2022

pwa-studio-bot commented Nov 7, 2022 • edited

Log

dpatil-magento commented Nov 9, 2022

pwa-test-bot bot commented Nov 9, 2022

dpatil-magento commented Nov 9, 2022

pwa-test-bot bot commented Nov 9, 2022

dpatil-magento commented Nov 9, 2022

pwa-test-bot bot commented Nov 9, 2022

dpatil-magento commented Nov 9, 2022

glo82145 commented Oct 3, 2022 •

edited by m2-assistant bot

pwa-studio-bot commented Oct 3, 2022 •

edited

pwa-studio-bot commented Nov 7, 2022 •

edited