Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update experience platform connector dependencies #4019

Merged

Conversation

jcalcaben
Copy link
Contributor

Description

Updates the experience platform connector dependencies to the latest versions.

Fixes add to cart event crashing app due to unset contexts.

Related Issue

Closes PWA-3048

Acceptance

Any core developer

Verification Stakeholders

@dpatil-magento

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jcalcaben jcalcaben added the version: Patch This changeset includes backwards compatible bug fixes. label Dec 16, 2022
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Dec 16, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Dec 16, 2022

Messages
📖

Associated JIRA tickets: PWA-3048.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 6d0c355

anthoula
anthoula previously approved these changes Dec 16, 2022
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Dec 16, 2022

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 504fc9a

@dpatil-magento
Copy link
Contributor

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Dec 19, 2022

Successfully started codebuild job for pr-test

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Dec 20, 2022

Successfully started codebuild job for lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Dec 20, 2022

Successfully started codebuild job for lighthouse-mobile

@dpatil-magento dpatil-magento merged commit 9f530d1 into release/13.0 Dec 20, 2022
@dpatil-magento dpatil-magento deleted the pwa-3048_fix-experience-platform-connector branch December 20, 2022 03:06
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:extensions pkg:peregrine Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants