Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Add more context to product page view event #4025

Merged

Conversation

jcalcaben
Copy link
Contributor

Description

Adds more data when setting the product page view context and dispatching the event.

Related Issue

Closes PWA-3050

Acceptance

@dpatil-magento

@dpatil-magento

Verification Stakeholders

@dpatil-magento

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jcalcaben jcalcaben added the version: Patch This changeset includes backwards compatible bug fixes. label Jan 3, 2023
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jan 3, 2023
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jan 3, 2023

Messages
📖

Associated JIRA tickets: PWA-3050.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 8ab0e75

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jan 5, 2023

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 8ab0e75

@dpatil-magento
Copy link
Contributor

QA Approved.

@dpatil-magento dpatil-magento merged commit d2bfde6 into release/13.0 Jan 5, 2023
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jan 5, 2023
@dpatil-magento dpatil-magento deleted the PWA-3050_fix-product-view-event-handler branch January 5, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:extensions pkg:peregrine Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants