-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Add more context to product page view event #4025
Merged
dpatil-magento
merged 3 commits into
release/13.0
from
PWA-3050_fix-product-view-event-handler
Jan 5, 2023
Merged
[Bugfix] Add more context to product page view event #4025
dpatil-magento
merged 3 commits into
release/13.0
from
PWA-3050_fix-product-view-event-handler
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalcaben
added
the
version: Patch
This changeset includes backwards compatible bug fixes.
label
Jan 3, 2023
|
anthoula
approved these changes
Jan 4, 2023
m2-community-project
bot
moved this from Ready for Review
to Reviewer Approved
in Pull Request Progress
Jan 4, 2023
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Jan 4, 2023
run cypress |
Successfully started codebuild job for |
LogERROR ON TASK: cypressTests
|
QA Approved. |
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:extensions
pkg:peregrine
Progress: done
version: Patch
This changeset includes backwards compatible bug fixes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more data when setting the product page view context and dispatching the event.
Related Issue
Closes PWA-3050
Acceptance
@dpatil-magento
@dpatil-magento
Verification Stakeholders
@dpatil-magento
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist