Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG#PWA-3215 Products not found using URL key #4183

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

RaghavendraTirumalasetti
Copy link
Contributor

Description

TODO: In the Venia theme, simple products won't load if they are not among the first 20 products.

Generate a Simple Product and set its visibility as "Catalog, Search."
Generate over 20 Bundle Products and link them to the previously created Simple Product.
Ensure the entity ID of the Simple Product is lower than the IDs of the Bundle Products.
Execute the GraphQL query below to filter the Simple Product's URL. The query will return the matching Bundle Products and the Simple Product.

Actual results
-> Product page is not loaded

Expected results
-> Product page should be loaded

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3215.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Oct 19, 2023
@RaghavendraTirumalasetti RaghavendraTirumalasetti changed the title BUG#PWA-3124 Products not found using URL key BUG#PWA-3125 Products not found using URL key Oct 19, 2023
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 19, 2023

Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-3215.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against fb6917b

@RaghavendraTirumalasetti RaghavendraTirumalasetti changed the title BUG#PWA-3125 Products not found using URL key BUG#PWA-3215 Products not found using URL key Oct 19, 2023
@glo82145 glo82145 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Oct 19, 2023
@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 19, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 19, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-mobile

1 similar comment
@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@dpatil-magento
Copy link
Contributor

run pr-test

2 similar comments
@dpatil-magento
Copy link
Contributor

run pr-test

@dpatil-magento
Copy link
Contributor

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Dec 20, 2023

Successfully started codebuild job for pr-test

@glo82145 glo82145 merged commit 7dd6bed into develop Mar 18, 2024
7 checks passed
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants