Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main v3 #4191

Merged
merged 36 commits into from
Oct 26, 2023
Merged

Sync main v3 #4191

merged 36 commits into from
Oct 26, 2023

Conversation

glo82145
Copy link
Collaborator

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

glo42707
glo42707 previously approved these changes Oct 23, 2023
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@glo82145
Copy link
Collaborator Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 25, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator Author

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 25, 2023

Successfully started codebuild job for lighthouse-mobile

glo42707
glo42707 previously approved these changes Oct 25, 2023
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@glo82145
Copy link
Collaborator Author

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 26, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 26, 2023

Successfully started codebuild job for lighthouse-desktop

Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@glo82145 glo82145 merged commit eb82887 into develop Oct 26, 2023
10 of 11 checks passed
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Oct 26, 2023
glo80771 added a commit that referenced this pull request Nov 29, 2023
glo82145 added a commit that referenced this pull request Mar 20, 2024
Co-authored-by: Aanchal Pawar <97873570+glo82145@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants