Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3217-V1::Thumbnail Images are getting hidden due to PR - BUG#PWA-… #4194

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

glo80771
Copy link
Contributor

@glo80771 glo80771 commented Nov 3, 2023

…3215

Description

Thumbnail Images are getting hidden due to PR - BUG#PWA-3215.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3217

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Nov 3, 2023
@glo80771 glo80771 added version: Patch This changeset includes backwards compatible bug fixes. and removed Progress: ready for review labels Nov 3, 2023
@m2-community-project m2-community-project bot moved this from Ready for Review to On Hold in Pull Request Progress Nov 3, 2023
@m2-community-project m2-community-project bot moved this from On Hold to Ready for Review in Pull Request Progress Nov 3, 2023
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Nov 3, 2023

Messages
📖

Associated JIRA tickets: PWA-3215.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against d8d6287

glo82145
glo82145 previously approved these changes Nov 9, 2023
@glo82145 glo82145 merged commit caa8187 into develop Mar 18, 2024
7 checks passed
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants