Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version update #4210

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Version update #4210

merged 1 commit into from
Dec 1, 2023

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Dec 1, 2023

Description

TODO: Updating version in packages/extensions

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3224

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Dec 1, 2023
@glo82145 glo82145 changed the base branch from release/13.4.0 to develop December 1, 2023 08:53
@glo82145 glo82145 changed the base branch from develop to release/13.4.0 December 1, 2023 08:54
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-3224.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 534d8f4

@glo82145 glo82145 changed the base branch from release/13.4.0 to develop December 1, 2023 09:04
glo42707
glo42707 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Dec 1, 2023
@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Dec 1, 2023
@glo82145 glo82145 merged commit 52229b2 into develop Dec 1, 2023
7 of 8 checks passed
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Dec 1, 2023
@glo82145 glo82145 deleted the version_update_v2 branch December 1, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glo42707 glo42707 glo42707 approved these changes

Assignees

@glo42707 glo42707

Labels
pkg:extensions Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glo82145 @pwa-studio-bot @glo42707