Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3178::Order statuses are decoupled from the back-end #4229

Merged
merged 16 commits into from
Apr 1, 2024
Merged

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Feb 2, 2024

Description

A refunded order will show a wrong status. Custom order statuses are not shown.

To reproduce

Steps to reproduce the behavior: Refund an order in the admin. Create a custom order status and assign it to an order.

navigate to /order-history
notice PWA-Studio's own take on order statuses
Expected behavior

The frontend should accurately show the status of the order.

Related Issue

Closes #PWA-3178

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 2, 2024

Messages
📖

Associated JIRA tickets: PWA-3178.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against ab4558b

@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Feb 2, 2024
@fooman
Copy link
Contributor

fooman commented Feb 13, 2024

In my opinion the solution should use the order state
https://github.com/magento/magento2-pwa/blob/main/SalesGraphQlAux/etc/schema.graphqls#L5
instead of doing any derived calculations.

Also note that "Delivered" will be inacurrate until such time that the delivery has arrived at the customer's address. The complete status will automatically get applied once all items in an order have been marked invoice and shipped. Delivered to most people would indicate they have the item in their physical posession.

@fooman
Copy link
Contributor

fooman commented Feb 13, 2024

Just linking the original issue report here as well
#3716

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Apr 1, 2024
@glo82145 glo82145 merged commit b38b527 into develop Apr 1, 2024
7 checks passed
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Apr 1, 2024
glo82145 added a commit that referenced this pull request Jun 5, 2024
* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* PWA-3178::Order statuses are decoupled from the back-end

* Resolved issue

* Resolved issue

* Resolved issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants