Vaimo bug fixes

[paveq]

Fixes bugs:

• JS collection errors on checkout (always call _super() on initObservable()
• Inorrect calculation when store credit is applied
• When free method is applied, strip title from request to backend so we don't get error 500
• If user selects COD payment, goes back to browse the site and comes back to checkout, it should now correctly refresh totals if other than COD method is selected

Improves:

• Only send COD total to frontend when COD method is selected
• Performance of observer SalesModelServiceQuoteSubmitBefore: do not load quote object again from database

[phoenix128]

@paveq , are you sure this is correctly working?
We intentionally loaded it from DB because it was not correctly working on our old Magento 2.0.7 installation, we had an empty quote object. Maybe a fixed bug?

[phoenix128]

We just tried on 2.1.0, it is not working properly. What is the version you tried?

[paveq]

I tried on 2.1.1 EE. What does $quote object in your case contain? Maybe we could have check that if it is null, then we retrieve from quoteRepository.

[phoenix128]

@paveq, it was just empty, but I'm seeing it works on 2.1.0, so it should be correct.
Now we see we have zero amount on payment method description (CE 2.1.0).

Something not working on getFeeLabel in MSP\CashOnDelivery\Model\CashondeliveryCart, we are checking it.

[phoenix128]

Ok, it does not work the first time you load, if you refresh it is working... We are checking it.