Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage for beta #45

Closed
magicDGS opened this issue Oct 23, 2016 · 3 comments
Closed

Code coverage for beta #45

magicDGS opened this issue Oct 23, 2016 · 3 comments
Milestone
Beta version (0.3.*)

Comments

@magicDGS
Copy link
Owner

Coverage should increase in beta to at least 80%. We should have a unit test for each component if possible, not only integration tests for all the tools.

Note: thresholds in codecov.yml should be changed.
@magicDGS magicDGS added this to the Beta version (0.3.0) milestone Oct 23, 2016
@magicDGS
Copy link
Owner Author

I don't know if it will be possible for beta, although we are around 77% now (cb6af68). I don't want to invest time to test deprecated classes that will disapear in version 1.

Keep it in beta to track the thresholds in codecov.yml. This is important because from version 1.0.0 on, changes to the source code will be contributed by PR and added directly to master.

@magicDGS
Copy link
Owner Author

develop at 08c70ba already have an 80.56% test coverage. Great!

@magicDGS
Copy link
Owner Author

magicDGS commented Feb 6, 2017

Coverage is already higher than 80% and the thresholds are changed in 2079088

@magicDGS magicDGS closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Beta version (0.3.*)
Development

No branches or pull requests
1 participant
@magicDGS