System change

[bolbolfolfol]

Hi
is there a way to add this module to system directly without instaling it as a module ?

i can add the service.sh to data/adb/service.d

but the system.prop values don't look normal to me

and thank you

[DerGoogler]

@bolbolfolfol, the system.prop is actually wrong configured.

@TukangM, please fix the system.prop file to a valid format (in both of your modules)

# This file will be read by resetprop
# Example: Change dpi
# ro.sf.lcd_density=320

net.eth0.dns1=94.140.14.14
net.eth0.dns2=94.140.15.15

net.dns1=94.140.14.14
net.dns2=94.140.15.15

net.ppp0.dns1=94.140.14.14
net.ppp0.dns2=94.140.15.15

net.rmnet0.dns1=94.140.14.14
net.rmnet0.dns2=94.140.15.15

net.rmnet1.dns1=94.140.14.14
net.rmnet1.dns2=94.140.15.15

net.pdpbr1.dns1=94.140.14.14
net.pdpbr1.dns2=94.140.15.15

DO NOT copy and paste!

[TukangM]

@TukangM, please fix the system.prop file to a valid format (in both of your modules)
https://github.com/Magisk-Modules-Repo/CloudflareDNS4Magisk/blob/master/system.prop . OK but maybe I just fork the repo from xerta555. but I created this repository only changing the cloudflare dns address to adguard dns.

DO NOT copy and paste!

https://xdaforums.com/t/q-permanently-set-dns-settings-without-app.1909019/
if I look at the xda forum. that seems like a valid configuration but for build.prop

[DerGoogler]

@TukangM, please fix the system.prop file to a valid format (in both of your modules)
https://github.com/Magisk-Modules-Repo/CloudflareDNS4Magisk/blob/master/system.prop . OK but maybe I just fork the repo from xerta555. but I created this repository only changing the cloudflare dns address to adguard dns.

DO NOT copy and paste!

https://xdaforums.com/t/q-permanently-set-dns-settings-without-app.1909019/ if I look at the xda forum. that seems like a valid configuration but for build.prop

[bolbolfolfol]

@bolbolfolfol, the system.prop is actually wrong configured.

That's what i tought, i never saw any .prop value have "space"

DO NOT copy and paste!

So what should i do now ?

[DerGoogler]

You could open an Pulli request where you remove the resetprop -n from each line.