Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is git-commit-fill-column considered obsolete? #3067

Closed
angrybacon opened this issue May 7, 2017 · 3 comments
Closed

Why is git-commit-fill-column considered obsolete? #3067

angrybacon opened this issue May 7, 2017 · 3 comments
Labels
support User needs some help

Comments

@angrybacon
Copy link

angrybacon commented May 7, 2017 •
edited
Loading

Here is the commit for reference: a277432

While git-commit-turn-on-auto-fill still uses it.
@kyleam
Copy link
Member

kyleam commented May 7, 2017 •
edited
Loading

git-commit-turn-on-auto-fill still uses it to accommodate users that
still set it.

I think #2848 contains most of the background on this.

@npostavs
Copy link
Contributor

npostavs commented May 7, 2017

Yep, short answer is, it's obsolete because it doesn't provide any functionality over plain old fill-column.

@kyleam kyleam added the support User needs some help label May 7, 2017
@angrybacon
Copy link
Author

angrybacon commented May 8, 2017 •
edited
Loading

Thanks, I'm advicing git-commit-turn-on-auto-fill adding a hook on git-commit-mode-hook then. Unless you want to keep the issue around, you can close it. 👌

@kyleam kyleam closed this as completed May 8, 2017
Binary-Eater added a commit to Binary-Eater/magit that referenced this issue May 1, 2023
@Binary-Eater
manual: Remove references to git-commit-fill-column
27eaeb3 
git-commit-fill-column was deprecated in Magit 2.9.0. It should be removed
from the manual to avoid confusion since the variable is no longer present
in the codebase.

Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Link: magit@a277432
Link: magit#3067
@Binary-Eater Binary-Eater mentioned this issue May 1, 2023
Merged
tarsius pushed a commit to Binary-Eater/magit that referenced this issue May 1, 2023
@Binary-Eater @tarsius
manual: Remove references to git-commit-fill-column
6d1933a 
git-commit-fill-column was deprecated in Magit 2.9.0. It should be removed
from the manual to avoid confusion since the variable is no longer present
in the codebase.

Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Link: magit@a277432
Link: magit#3067
conao3 pushed a commit to conao3/jadoc that referenced this issue Jan 4, 2024
@Binary-Eater @tarsius
manual: Remove references to git-commit-fill-column
5145bc9 
git-commit-fill-column was deprecated in Magit 2.9.0. It should be removed
from the manual to avoid confusion since the variable is no longer present
in the codebase.

Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Link: magit/magit@a277432
Link: magit/magit#3067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
support User needs some help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@npostavs @kyleam @angrybacon