* lisp/magit-git.el magit-cygwin-prefix magit-expand-git-file-name #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `magit-cygwin-prefix' in `magit-expand-git-file-name' instead of hard-coded cygdrive prefix.
|
I think we're in danger of reimplementing cygwin-mount.el. |
|
Yes but actually magit-expand-git-file-name doesn't work if the prefix is different of cygdrive ... |
Right, so I'm suggesting instead of magit redoing all the mount point parsing, maybe we should suggest cygwin users install cygwin-mount.el and then we can call |
|
Yes, but may be cygwin-mount is overkill for this isn't it ? I think the patch could be improved by adding tests on system-type etc. |
|
See PR #2324. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2317 for complement.