magit use hard-coded mount prefix #2324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `magit-cygwin-prefix' in `magit-expand-git-file-name' instead of hard-coded cygdrive prefix. Use `defcustom' for `magit-cygwin-prefix' and add extra checks for default value. Set value to nil when the system isn't windows-nt.
This was referenced Oct 9, 2015
|
Can you update this to handle fancier mappings as shown in #2317 (comment)? You'll need to parse the lines from |
|
@PierreTechoueyres do you intend to improve this pr very soon - or should we do it ourselves. This is one of the blockers for the next release. |
|
I'll try to do it a the end of the week. I'm little busy at work theses days. |
|
@PierreTechoueyres did you find time to look at this? If not, I'll try to do it tonight. |
|
@npostavs No sorry. |
|
It's okay, I hear "a life" can be very time consuming for those who have one ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
magit-cygwin-prefixinmagit-expand-git-file-nameinstead of hard-coded cygdrive prefix.Use
defcustomformagit-cygwin-prefixand add extra checks for default value.Set return value to
nilwhen the system isn'twindows-nt.