fix: bazel base uses same folly version as magma vm #13743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
nstng
commented
Aug 25, 2022
nstng
commented
Aug 25, 2022
| # setup magma artifactories and install magma dependencies | ||
| RUN wget -qO - https://artifactory.magmacore.org:443/artifactory/api/gpg/key/public | apt-key add - && \ | ||
| add-apt-repository 'deb https://artifactory.magmacore.org/artifactory/debian-test focal-ci main' && \ | ||
| add-apt-repository 'deb https://artifactory.magmacore.org/artifactory/debian-test focal-1.7.0 main' && \ |
There was a problem hiding this comment.
This must have been forgotten - just does not make sense and is not needed.
nstng
commented
Aug 25, 2022
| apt-get update -y && \ | ||
| apt-get install -y --no-install-recommends \ | ||
| bcc-tools \ | ||
| libfolly-dev \ |
There was a problem hiding this comment.
This is the replacement for the manual fmt and folly build above.
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
nstng
force-pushed
the
bazel_base_uses_same_folly_as_vm
branch
from
564215a
to
b88e31d
Compare
pull-request-size
bot
added
size/M
github-actions
bot
added
the
component: ci
nstng
force-pushed
the
bazel_base_uses_same_folly_as_vm
branch
from
e39b24f
to
b88e31d
Compare
LKreutzer
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Tested locally.
With the artifact from the old container I get a
/sessiond: error while loading shared libraries: libfolly.so.0.58.0-dev: cannot open shared object file: No such file or directory
And with the new container it is running.
bazel test ... is passing in the new container.
1 task
nstng
added a commit
to nstng/magma
that referenced
this pull request
Aug 26, 2022
)" This reverts commit d08d78f. Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
maxhbr
pushed a commit
that referenced
this pull request
Aug 26, 2022
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Sep 4, 2022
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Sep 4, 2022
)" (magma#13753) This reverts commit d08d78f. Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
Note: this change was reverted in #13753 - this will be redone and needs a more sophisticated release strategy
This change makes the bazel base container use the same folly version as the magma vm. If this is not the case then sessiond builds can not run the respective other environment.
Also did small changes I will add as comments in the code here.
This change must not be merged until the updated folly debian file in #13741 is uploaded to focal-ci. [edit] done
Test Plan
docker build -f .devcontainer/bazel-base/Dockerfile -t bb:latest .docker run -v ${MAGMA_ROOT}:/workspaces/magma/ -v ${MAGMA_ROOT}/lte/gateway/configs:/etc/magma/ -it bb:latest /bin/bashbazel test ...)Additional Information