Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: bazel base uses same folly version as magma vm (#13743)" #13753

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Aug 26, 2022

This reverts commit d08d78f.

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

)"

This reverts commit d08d78f.

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 26, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@LKreutzer LKreutzer self-requested a review August 26, 2022 12:00
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 1039e68.

@maxhbr maxhbr merged commit 4a878d8 into magma:master Aug 26, 2022
rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022
)" (magma#13753)

This reverts commit d08d78f.

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants