Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agw): Downgrade sentry-sdk, grpcio and spyne #13795

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix(agw): Downgrade sentry-sdk, grpcio and spyne #13795

merged 1 commit into from
Aug 31, 2022

Conversation

sebathomas
Copy link
Contributor

@sebathomas sebathomas commented Aug 31, 2022 •
edited by shashidhar-patil

Summary

The Python dependency upgrades generated a broken magma Debian package with higher dependencies that could not be fulfilled (see #13787).

Additionally, the new version of spyne breaks the CI due to permission issues.

Test Plan

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Aug 31, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: orc8r Orchestrator-related issue labels Aug 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit b3a9c6c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022 •
edited

cloud-workflow

1 017 tests   1 017 ✔️  2m 9s ⏱️
   356 suites         0 💤
       7 files           0 ❌

Results for commit b3a9c6c.

♻️ This comment has been updated with latest results.

@sebathomas sebathomas marked this pull request as ready for review August 31, 2022 15:31
@sebathomas sebathomas requested a review from a team as a code owner August 31, 2022 15:31
@sebathomas sebathomas requested review from a team, ardzoht and andreilee August 31, 2022 15:31
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022 •
edited

dp-workflow

14 tests   14 ✔️  3m 4s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b3a9c6c.

♻️ This comment has been updated with latest results.

@sebathomas
fix(agw): Downgrade sentry-sdk, grpcio and spyne
b3a9c6c 
The Python dependency upgrades generated a broken magma debian
package with higher dependencies that could not be fullfilled.

Additionally, the new version of spyne breaks the CI due to
permission issues.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
@sebathomas sebathomas changed the title fix(agw): Downgrade sentry-sdk and grpcio fix(agw): fix(agw): Downgrade sentry-sdk, grpcio and spyne Aug 31, 2022
@sebathomas sebathomas changed the title fix(agw): fix(agw): Downgrade sentry-sdk, grpcio and spyne fix(agw): Downgrade sentry-sdk, grpcio and spyne Aug 31, 2022
maxhbr
maxhbr approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebathomas sebathomas enabled auto-merge (squash) August 31, 2022 16:25
@sebathomas sebathomas merged commit f8cc54f into magma:master Aug 31, 2022
@MoritzThomasHuebner MoritzThomasHuebner mentioned this pull request Sep 1, 2022
Merged
1 task
@sebathomas sebathomas mentioned this pull request Sep 2, 2022
Merged
2 tasks
rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022
@sebathomas @rsarwad
fix(agw): Downgrade sentry-sdk, grpcio and spyne (magma#13795)
2b07830 
The Python dependency upgrades generated a broken magma debian
package with higher dependencies that could not be fullfilled.

Additionally, the new version of spyne breaks the CI due to
permission issues.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhbr maxhbr maxhbr approved these changes

@ajahl ajahl ajahl approved these changes

@ardzoht ardzoht Awaiting requested review from ardzoht ardzoht was automatically assigned from magma/approvers-agw

@andreilee andreilee Awaiting requested review from andreilee

Assignees
No one assigned
Labels
component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: orc8r Orchestrator-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebathomas @maxhbr @ajahl