fix(agw): Fix reinstall logic and error handling in pydep #13799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using install could lead to situations where the package is already installed but not recognized by the python environment. Explicitly running reinstall solves this issue. Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
github-actions
bot
added
the
component: ci
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
MoritzThomasHuebner
force-pushed
the
idna_import_fix
branch
from
b6d60d7
to
75b6ab8
Compare
MoritzThomasHuebner
force-pushed
the
idna_import_fix
branch
from
75b6ab8
to
565148b
Compare
nstng
reviewed
Sep 1, 2022
sebathomas
reviewed
Sep 1, 2022
| @@ -1086,7 +1086,7 @@ def main(args): | |||
| pip_packages = [req.key for req in repo_installable] | |||
| subprocess.call(shlex.split('sudo pip3 uninstall -y ' | |||
| + ' '.join(pip_packages))) | |||
| subprocess.call(shlex.split('sudo apt install -y ' | |||
| subprocess.call(shlex.split('sudo apt reinstall -y ' | |||
This prevents the fabric script from failing if no dependencies have been built. Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
MoritzThomasHuebner
force-pushed
the
idna_import_fix
branch
from
565148b
to
4bd993e
Compare
sebathomas
reviewed
Sep 1, 2022
pull-request-size
bot
added
size/S
MoritzThomasHuebner
force-pushed
the
idna_import_fix
branch
from
11663ee
to
4bd993e
Compare
pull-request-size
bot
added
size/XS
Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
sebathomas
approved these changes
Sep 1, 2022
alexzurbonsen
approved these changes
Sep 1, 2022
sebathomas
changed the title
This was referenced Sep 1, 2022
Closed
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Sep 4, 2022
- Changed the pydep script to reinstall all packages with apt since already installed packages might not be registered with python. This solves an issue in the build process where the uninstallation of "idna" breaks some Python scripts. - Fixed the error handling of fabric (catching exceptions does not work) so the script can run even if no new dependencies are built. Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> Co-authored-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to:
#13795
See also:
#13787
Summary
pydepscript to reinstall all packages with apt since already installed packages might not be registered with python. This solves an issue in the build process where the uninstallation of "idna" breaks some Python scripts.Test Plan
I made a temporary change to trigger the AGW build workflow.
https://github.com/sebathomas/magma/actions/runs/2971214324
Additional Information