Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Fix spyne version in pydep lockfile #13809

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

sebathomas
Copy link
Contributor

@sebathomas sebathomas commented Sep 2, 2022

Summary

The CI still builds a Magma package with a higher spyne dependency than what is available in artifactory. This may be because the local run generating the lockfile in #13795 obtained a higher version than the run in the CI that only worked after other issues were fixed in #13799.

Test Plan

Additional Information

  • This change is backwards-breaking

@sebathomas sebathomas requested a review from a team as a code owner September 2, 2022 06:46
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 18f1b1d.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

agw-workflow

615 tests   611 ✔️  4m 28s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 18f1b1d.

@sebathomas sebathomas merged commit e2e032c into magma:master Sep 2, 2022
rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022
Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants