-
Notifications
You must be signed in to change notification settings - Fork 138
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[#200] Define setters for -first-item and -last-item
- Loading branch information
Matus Goljer
committed
Nov 8, 2016
1 parent
53e641c
commit bcc74b5
Showing
1 changed file
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcc74b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
bcc74b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, looks like this doesn't work on Emacs 23 -- it's broken the tests.
bcc74b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I've noticed too :( Do you know a fix? Apparently gv did not exist back then. But it's not a big deal as we'll be dropping emacs 23 tests soon (as per #195)
bcc74b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there was equivalent functionality in Emacs 23, which we could use. Alternatively, why not just wrap in a
(when (boundp 'gv-define-setter') ...)
and treat this as an extra feature for recent Emacsen?bcc74b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we would also need to guard tests and there it can be messy. If you know how to make this work in e23 I'd rather have that added.
bcc74b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's
define-setf-expander
on Emacs 23 (which works on recent Emacsen too), ordefsetf
. I'm struggling: Emacs 23 segfaults during compile on my Arch Linux box, and the EVM binaries depend on versions of libtinfo which aren't compatible with Arch Linux's default ncurses install.IIUC, I think this could be written: