Fix wrong type argument on Emacs 28.1 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading from Emacs 27 to 28.1, loading expand-region breaks with the error message "Wrong type argument: stringp, (require . package)" This is due to using eval-after-load with a string argument. This odd call style was introduced in magnars#213 However, the assertion that text-mode is missing a provide call hasn't been true in 6 years: emacs-mirror/emacs@f70f9a5
|
cc: @Wilfred, who authored the PR mentioned Caveat: I'm not an elisp programmer |
|
Thanks! |
|
Thanks for expand-region, my favorite emacs package
…On Fri 29. Jul 2022 at 08:59, Magnar Sveen ***@***.***> wrote:
Thanks!
—
Reply to this email directly, view it on GitHub
<#275 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZ6WGWFO2K3M6UVCTVXHLVWN6OXANCNFSM546XBIPA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading from Emacs 27 to 28.1, loading expand-region
breaks with the error message "Wrong type argument: stringp, (require .
package)"
This is due to using eval-after-load with a string argument. This odd
call style was introduced in
#213
However, the assertion that text-mode is missing a provide call hasn't
been true in 6 years:
emacs-mirror/emacs@f70f9a5