-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4.3.2 #262
Release v4.3.2 #262
Conversation
Bugfix in HalfEarth Scenario: Synchronization until 2020 with WDPA protection scenario
Replaced TravisCI with GitHubActions
bugfix m_fillmissingyears macro
… demand model and the magpie model are now reported over each iteration. Moreover, the numbering of iterations was increased by 1 (starting now at iteration 1 instead of 0) The covergence criterium was lifted to a maximum of 1% income difference of one single region (instead of 0.5% before).
… NUE as an interface to the emission module equations were sepearted into several, whcih makes reading easier and is a preparation for an emission module that will be based on nitrogen surplus
… ovoid overspecialization of plantation establishment towards highly productive cells.
…nd s35_hvarea = 2., otherwise infeasible (Upper bound in trade module).
Reshuffling of forestry, natveg and timber module code : Better routine for timber production inclusing performance updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Good to go 💎 🙌🏽 📈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor code cleanup changes requested.
@tscheypidi what would be the best way to address the requested changes? Branch out from my commits at #249, call it rc in my fork, make a PR for my fork's rc with main model's rc? |
I marked most of the requests resolved. @FelicitasBeier can you also check if #262 (comment) is okay? (Also if you'd like to re-open the changes I marked resolved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 ready to go
Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):
Purpose of this PR
Release of MAgPIE v4.3.2