-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix in HalfEarth Scenario: Synchronization until 2020 with WDPA protection scenario #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. So WDPA is active till 2020 and then additional protection after 2020 with half-earth (WDPA+something). I'll approve it but would recommend waiting until @flohump also approves it.
UPDATE: The HalfEarth scenario now fades in until 2050. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue needs to be resolved in presolve line 76
Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):
Purpose of this PR
Performance loss/gain from current default behavior
Type of change
How Has This Been Tested?
test_runs.R
).test_runs.R
but with the changes from PR.Additions or Changes to default configuration (default.cfg):
no additions required
Changes are deletion or updates to the existing model components in default config
Checklist:
CHANGELOG.md
(I think this is not required, since it was only a bugfix, right?)goxygen::goxygen()
for the new/updated parts.magpie4
R library for post processing of model output (ideally backward compatible).Special comments/warnings