-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix SOM, TC cost and Biodiversity Module + new Biodiversity Module realization #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one part of code where I had the feeling that it is not yet mentioned in the CHANGELOG (see my separate comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I absolutely like these new additions to the biodiversity module! Many thanks! I have only minor suggestions that you'll find directly in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just found a couple of typos that I changed directly
Co-authored-by: pvjeetze <50408549+pvjeetze@users.noreply.github.com>
Co-authored-by: pvjeetze <50408549+pvjeetze@users.noreply.github.com>
Co-authored-by: pvjeetze <50408549+pvjeetze@users.noreply.github.com>
🐦 Purpose of this PR 🐦
44_biodiverstiy/bv_btc_mar21
: accounting for time step length44_biodiverstiy/bii_target
added AND set as new default in default.cfg🔧 Checklist for PR creator 🔧
22LandConsvBetaRun3_default_rest1_all_marginal
PR399_SSP2-Ref
PR399_SSP2-Ref_BII
📉 Performance loss/gain from current default behavior 📈
Added changes to
CHANGELOG.md
Compilation check (model starts without compilation errors - use
gams main.gms action=c
in model folder for testing).No hard coded numbers and cluster/country/region names.
The new code doesn't contain declared but unused parameters or variables.
Where relevant, In-code comments added including documentation comments.
Made sure that documentation created with
goxygen
is okay (usegoxygen::goxygen()
for testing).Changes to
magpie4
R library for post processing of model output (ideally backward compatible).Self-review of my own code.
For high risk runs: validation of major model indicators - Land-use, emissions, food prices, Tau. %Delete this line in case it is not a high risk run%
NA
🚨 Checklist for RSE reviewer 🚨
CHANGELOG
is updated correctly🚨 Checklist for MAgPIE reviewer 🚨
CHANGELOG
is updated correctly