Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Guava's ReverseList. #55

Merged
merged 2 commits into from
Oct 4, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
package de.javakaffee.kryoserializers.guava;

import com.google.common.collect.Lists;

import com.esotericsoftware.kryo.Kryo;
import com.esotericsoftware.kryo.Serializer;
import com.esotericsoftware.kryo.io.Input;
import com.esotericsoftware.kryo.io.Output;
import com.esotericsoftware.kryo.serializers.CollectionSerializer;

import java.util.ArrayList;
import java.util.LinkedList;
import java.util.List;

/**
* A {@link Lists.ReverseList} Serializer.
* Treat as a {@link List} by reversing before write and after read.
*/
public abstract class ReverseListSerializer extends Serializer<Object> {

private static final CollectionSerializer serializer = new CollectionSerializer();

@SuppressWarnings("unchecked")
@Override
public void write(Kryo kryo, Output output, Object object) {
// reverse the ReverseList to get the "forward" list, and treat as regular List.
List forwardList = Lists.reverse((List<Object>) object);
serializer.write(kryo, output, forwardList);
}

@SuppressWarnings("unchecked")
@Override
public Object copy(Kryo kryo, Object original) {
List forwardList = Lists.reverse((List) original);
return Lists.reverse((List<Object>) serializer.copy(kryo, forwardList));
}

public static void registerSerializers(final Kryo kryo) {
kryo.register(Lists.reverse(Lists.newLinkedList()).getClass(), forReverseList());
kryo.register(Lists.reverse(Lists.newArrayList()).getClass(), forRandomAccessReverseList());
}

public static ReverseListSerializer forReverseList() {
return new ReverseListSerializer.ReverseList();
}

public static ReverseListSerializer forRandomAccessReverseList() {
return new ReverseListSerializer.RandomAccessReverseList();
}

/**
* A {@link Lists.ReverseList} implementation based on a {@link LinkedList}.
*/
private static class ReverseList extends ReverseListSerializer {

@SuppressWarnings("unchecked")
@Override
public Object read(Kryo kryo, Input input, Class<Object> type) {
// reading a "forward" list as a LinkedList and returning the reversed list.
List forwardList = (List) serializer.read(kryo, input, (Class) LinkedList.class);
return Lists.reverse(forwardList);
}
}

/**
* A {@link Lists.ReverseList} implementation based on an {@link ArrayList}.
*/
private static class RandomAccessReverseList extends ReverseListSerializer {

@SuppressWarnings("unchecked")
@Override
public Object read(Kryo kryo, Input input, Class<Object> type) {
// reading a "forward" list as a ArrayList and returning the reversed list.
List forwardList = (List) serializer.read(kryo, input, (Class) ArrayList.class);
return Lists.reverse(forwardList);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
package de.javakaffee.kryoserializers.guava;

import com.google.common.collect.Lists;

import com.esotericsoftware.kryo.Kryo;

import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;

import java.util.Arrays;
import java.util.Collections;
import java.util.List;

import static de.javakaffee.kryoserializers.KryoTest.deserialize;
import static de.javakaffee.kryoserializers.KryoTest.serialize;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;


/**
* Test for {@link ReverseListSerializer}.
*/
public class ReverseListSerializerTest {

private Kryo _kryo;

@BeforeTest
public void setUp() throws Exception {
_kryo = new Kryo();

ReverseListSerializer.registerSerializers(_kryo);
}

@Test( enabled = true )
public void testEmptyReverseList() {
testEmpty(Lists.reverse(Lists.newLinkedList()));
}

@Test( enabled = true )
public void testEmptyRandomAccessReverseList() {
testEmpty(Lists.reverse(Lists.newArrayList()));
}

private void testEmpty(final List<?> reverseList) {
final byte[] serialized = serialize( _kryo, reverseList );
final List<?> deserialized = deserialize(_kryo, serialized, reverseList.getClass());
assertEquals(deserialized.getClass(), reverseList.getClass());
assertTrue(deserialized.isEmpty());
assertEquals(deserialized.size(), reverseList.size());
}

@Test( enabled = true )
public void testSingletonReverseList() {
testSingleton(Lists.reverse(Lists.newLinkedList(Collections.singleton(3))));
}

@Test( enabled = true )
public void testSingletonRandomAccessReverseList() {
testSingleton(Lists.reverse(Lists.newArrayList(Collections.singleton(3))));
}

private void testSingleton(final List<?> reverseList) {
final byte[] serialized = serialize( _kryo, reverseList );
final List<?> deserialized = deserialize(_kryo, serialized, reverseList.getClass());
assertEquals(deserialized.getClass(), reverseList.getClass());
assertEquals(deserialized, reverseList);
}

@Test( enabled = true )
public void testRegularReverseList() {
testRegular(Lists.reverse(Lists.newLinkedList(Arrays.asList(3, 4, 5, 6))));
}

@Test( enabled = true )
public void testRegularRandomAccessReverseList() {
testRegular(Lists.reverse(Lists.newArrayList(3, 4, 5, 6)));
}

private void testRegular(final List<?> reverseList) {
final byte[] serialized = serialize( _kryo, reverseList );
final List<?> deserialized = deserialize(_kryo, serialized, reverseList.getClass());
assertEquals(deserialized.getClass(), reverseList.getClass());
assertEquals(deserialized, reverseList);
}

// Kryo#copy tests

@Test( enabled = true )
public void testCopyEmptyReverseList() {
testCopy(Lists.reverse(Lists.newLinkedList()));
}

@Test( enabled = true )
public void testCopyEmptyRandomAccessReverseList() {
testCopy(Lists.reverse(Lists.newArrayList()));
}

@Test( enabled = true )
public void testCopySingletonReverseList() {
testCopy(Lists.reverse(Lists.newLinkedList(Collections.singleton(3))));
}

@Test( enabled = true )
public void testCopySingletonRandomAccessReverseList() {
testCopy(Lists.reverse(Lists.newArrayList(Collections.singleton(3))));
}

@Test( enabled = true )
public void testCopyRegularReverseList() {
testCopy(Lists.reverse(Lists.newLinkedList(Arrays.asList(3, 4, 5, 6))));
}

@Test( enabled = true )
public void testCopyRegularRandomAccessReverseList() {
testCopy(Lists.reverse(Lists.newArrayList(3, 4, 5, 6)));
}

private void testCopy(List<?> obj) {
final List<?> copied = _kryo.copy(obj);
assertEquals(copied.getClass(), obj.getClass());
assertEquals(copied, obj);
}
}