-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Guava's ReverseList. #55
Conversation
R: @magro |
7eaa02f
to
26ebad4
Compare
… ReverseListSerializer. unused import
4ad8f5a
to
5db1485
Compare
Thanks for the PR, I just released it with 0.39. |
Great! happy to hear that. |
Btw, I also just updated the kryo dependency to 4.0.0 and released kryo-serializers 0.40 with this. |
I'm mostly using Kryo with Spark so I assume that might not play nicely together 😉. |
Ah ok, might take a bit, as long as you cannot change the used kryo version on your own... |
@magro quick question - can I use version |
@amitsela Hmm, not sure, you could give it a try. If course you'd have to exclude the kryo dependency from kryo-serializers to stay with kryo 2.21. |
@magro Yeah, did that, just worried about backward compatibility, though I'm only using kryo-serializers for Guava immutables and Java's UnmodifiableCollection: UnmodifiableCollectionsSerializer.registerSerializers(kryo);
// Guava
ImmutableListSerializer.registerSerializers(kryo);
ImmutableSetSerializer.registerSerializers(kryo);
ImmutableMapSerializer.registerSerializers(kryo);
ImmutableMultimapSerializer.registerSerializers(kryo);
ReverseListSerializer.registerSerializers(kryo); |
@amitsela So does it work? |
@magro Seems to... I know for sure that |
Great! |
Supporting Guava's ReverseList (and RandomAccessReverseList).
First time writing a Kryo serializer, appreciate the feedback.
Thanks!
This change is